fix: Use a single timestamp in server_info - #3156
Open
snowyukitty wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
godexsoft
requested changes
Jul 30, 2026
godexsoft
left a comment
godexsoft
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, this is great! just one nit and i think this is good to go 👍
| auto const ledgerHeader = createLedgerHeaderWithUnixTime(kLedgerHash, 30, kNowUnix + 5); | ||
| runNormalRequest(ledgerHeader, [&](auto const& output) { | ||
| ASSERT_TRUE(output); | ||
| auto const& validated = output.result.value() |
Collaborator
There was a problem hiding this comment.
Perhaps some intermediate references here would make it look a little nicer 🔢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server_infosampledsystem_clockonce when constructingInfoSection::timeand again when calculating
validated_ledger.age. If those samples straddled awhole-second boundary, the exact-age assertions could fail intermittently.
This change reuses the timestamp already stored in
output.info.timefor theage calculation. The clock remains
system_clockby default; making itinjectable lets the tests use fixed absolute ledger times and verify that
successful requests sample it exactly once. A regression test also preserves
the existing zero clamp for future close times.
Fix #2353
Testing
RPCServerInfoHandlerTest.*: 12 passed; repeated 100 times (1,200 executions)-Werror; affected Clang 19 translation units1.14.0